=cycle-themes= kill buffers bug

description

When running cycle-themes, I'd get prompted:

The current server still has clients; delete them?

what it ended up being

enable-theme makes a call to custom-theme-recalc-variable , which in turn runs:

(funcall (or (get variable 'custom-set) #'set-default) variable

Some of the variables in question are also minor modes, among them server-mode. Which for some reason was set to t in Custom?

fixed it by

removing that from custom. we were fine then.

things I did to debug

M-x debug-on-entry enable-theme, then step through the frames until the truly inexplicable moment happened where server-mode was being set to t.